nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] mattyb149 commented on a change in pull request #4453: NIFI-7710 - Flow XML validation warnings for DataSize
Date Tue, 01 Sep 2020 14:38:35 GMT

mattyb149 commented on a change in pull request #4453:
URL: https://github.com/apache/nifi/pull/4453#discussion_r481187676



##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/resources/FlowConfiguration.xsd
##########
@@ -434,7 +434,7 @@
 
     <xs:simpleType name="DataSize">
         <xs:restriction base="xs:string">
-            <xs:pattern value="\d+\s*(B|KB|MB|GB|TB|b|kb|mb|gb|tb)" />
+            <xs:pattern value="\d+(\.\d+)?\s*(B|KB|MB|GB|TB|b|kb|mb|gb|tb)" />

Review comment:
       This doesn't exactly match the regex in the validator: `(\d+(?:\.\d+)?)\s*(B|KB|MB|GB|TB)`,
do we need the lookahead in the regex (meaning should they match exactly)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message