nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #857: MINIFICPP-1309 - RAII based resourceClaim management
Date Tue, 01 Sep 2020 11:04:18 GMT

adamdebreceni commented on a change in pull request #857:
URL: https://github.com/apache/nifi-minifi-cpp/pull/857#discussion_r481055566



##########
File path: libminifi/include/ResourceClaim.h
##########
@@ -104,9 +96,8 @@ class ResourceClaim : public std::enable_shared_from_this<ResourceClaim>
{
   }
 
  protected:
-  std::atomic<bool> deleted_;
   // Full path to the content
-  std::string _contentFullPath;
+  const Path _contentFullPath;

Review comment:
       a few lines below this we have the copy ctor and the copy assignment declared but undefined
and the comment:
   
   > // Prevent default copy constructor and assignment operation
   // Only support pass by reference or pointer
   
   so I think based on this, ResourceClaim was intended to be a `immutable type` of which,
the linked resource claims the following:
   
   > There is one useful-but-unusual design that may mandate const members: intentionally
immutable types. Instances of such a type are immutable after construction: no mutating methods,
no assignment operators. 
   
   of course this might not mean anything, I can remove the `const`, should I do it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message