nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] Wastack commented on a change in pull request #4370: NIFI-6128 UnpackContent: Store unpacked file data
Date Mon, 13 Jul 2020 09:20:26 GMT

Wastack commented on a change in pull request #4370:
URL: https://github.com/apache/nifi/pull/4370#discussion_r453512358



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UnpackContent.java
##########
@@ -321,6 +337,13 @@ public void process(final InputStream in) throws IOException {
                                 attributes.put(CoreAttributes.ABSOLUTE_PATH.key(), absPathString);
                                 attributes.put(CoreAttributes.MIME_TYPE.key(), OCTET_STREAM);
 
+                                attributes.put(FILE_PERMISSIONS_ATTRIBUTE, FileInfo.permissionToString(tarEntry.getMode()));
+                                attributes.put(FILE_OWNER_ATTRIBUTE, String.valueOf(tarEntry.getUserName()));
+                                attributes.put(FILE_GROUP_ATTRIBUTE, String.valueOf(tarEntry.getGroupName()));
+
+                                final String timeAsString = DATE_TIME_FORMATTER.format(tarEntry.getModTime().toInstant());
+                                attributes.put(FILE_LAST_MODIFIED_TIME_ATTRIBUTE, timeAsString);

Review comment:
       Let's modify file.creationTime to the same as lastModifiedTime in order to avoid (minimize)
confusion.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message