From issues-return-99147-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Jun 23 12:12:02 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACBD61804BB for ; Tue, 23 Jun 2020 14:12:01 +0200 (CEST) Received: (qmail 59402 invoked by uid 500); 23 Jun 2020 12:12:01 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 59393 invoked by uid 99); 23 Jun 2020 12:12:01 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 Jun 2020 12:12:01 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_tpalfy_commented_on_a_change_in_pull_reque?= =?utf-8?q?st_=234350=3A_NIFI-6934_In_PutDatabaseRecord_added_Postgres_UPSER?= =?utf-8?q?T_support?= Message-ID: <159291432095.8807.12339704836425227921.asfpy@gitbox.apache.org> Date: Tue, 23 Jun 2020 12:12:00 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: tpalfy commented on a change in pull request #4350: URL: https://github.com/apache/nifi/pull/4350#discussion_r444174839 ########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java ########## @@ -29,6 +29,8 @@ import org.apache.nifi.annotation.lifecycle.OnScheduled; Review comment: Unfortunately we will have to settle for manual testing. `TestMSSQLDatabaseAdapter` is not suitable for testing non-standard functionality (it uses derby). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org