nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [nifi] Wastack opened a new pull request #4356: NIFI-7576 ListenHTTP: Honor primary node only attribute
Date Tue, 23 Jun 2020 11:39:31 GMT

Wastack opened a new pull request #4356:

   ListenHTTP processor now binds port and creates a HTTP connection only
   if one of the following conditions apply:
   - Primary node execution is 'false'
   - Primary node execution is 'true' and node is elected as primary node.
   - Connection is established in 'onTrigger' annotated method instead of
     'onSchedule'. (This is similar to how handleHTTPRequest processor
     handles connections.)
   - 'onPrimaryNodeStateChange' annotated method is introduced to tear down
     server on reelection of primary node
   Thank you for submitting a contribution to Apache NiFi.
   Please provide a short description of the PR here:
   #### Description of PR
   _Enables X functionality; fixes bug NIFI-YYYY._
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [ x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   - [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
   - [ x] Has your PR been rebased against the latest commit within the target branch (typically
   - [ x] Is your initial contribution a single, squashed commit? _Additional commits in response
to PR reviewer feedback should be made on this branch and pushed to allow change tracking.
Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check
clean install` at the root `nifi` folder?
   - [x] Have you written or updated unit tests to verify your changes?
   - [x] Have you verified that the full build is successful on JDK 8?
   - [ ] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](

   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE`
file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file
found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic
access) for each of the new properties?
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues
and submit an update to your PR as soon as possible.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

View raw message