nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] jfrazee opened a new pull request #4341: NIFI-7540: Fix TestListenSMTP and TestListFile on macOS build environment
Date Tue, 16 Jun 2020 21:35:05 GMT

jfrazee opened a new pull request #4341:
URL: https://github.com/apache/nifi/pull/4341


   TestListenSMTP tests started failing again on the macOS GitHub builds after an update to
the macOS virtual environment for GitHub Actions [1]. This PR refactors TestListenSMTP so
it isn't fussy about the concurrency and timing of the tests and makes the assertions more
informative (which resolves NIFI-4760).
   
   This also adjusts the timings in TestListFile so its not as sensitive when there's second-only
mtime resolution.
   
   1. https://github.com/actions/virtual-environments/blob/master/images/macos/macos-10.15-Readme.md
   
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are
trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [X] Has your PR been rebased against the latest commit within the target branch (typically
`master`)?
   
   - [X] Is your initial contribution a single, squashed commit? _Additional commits in response
to PR reviewer feedback should be made on this branch and pushed to allow change tracking.
Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
   
   ### For code changes:
   - [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check
clean install` at the root `nifi` folder?
   - [X] Have you written or updated unit tests to verify your changes?
   - [X] Have you verified that the full build is successful on JDK 8?
   - [X] Have you verified that the full build is successful on JDK 11?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

   - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE`
file under `nifi-assembly`?
   - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file
found under `nifi-assembly`?
   - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic
access) for each of the new properties?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues
and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message