nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations
Date Thu, 04 Jun 2020 09:04:19 GMT

hunyadi-dev commented on a change in pull request #789:
URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r435102753



##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -696,13 +695,13 @@ class FileUtils {
     return {};
   }
 #endif /* WIN32 */
-};
+}; // NOLINT

Review comment:
       This is the error produced here:
   ```
    698:1  error  cpplint  You don't need a ; after a }  [readability/braces] [4]
   ```
   This is probably due the linter getting confused by preceeding `/*` style multiline comments.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message