nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations
Date Tue, 02 Jun 2020 16:35:12 GMT

hunyadi-dev commented on a change in pull request #789:
URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r434016382



##########
File path: libminifi/include/core/PropertyValidation.h
##########
@@ -85,8 +87,7 @@ class ValidationResult {
 
 class PropertyValidator {
  public:
-
-  PropertyValidator(std::string name)
+  explicit PropertyValidator(std::string name)

Review comment:
       Resolved by removing `explicit` and adding `// NOLINT`

##########
File path: libminifi/include/core/Resource.h
##########
@@ -1,68 +1,70 @@
-/**
- *
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements.  See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-#ifndef LIBMINIFI_INCLUDE_CORE_RESOURCE_H_
-#define LIBMINIFI_INCLUDE_CORE_RESOURCE_H_
-
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN 1
-#endif
-
-#include "ClassLoader.h"
-#include "agent/agent_docs.h"
-
-namespace org {
-namespace apache {
-namespace nifi {
-namespace minifi {
-namespace core {
-
-#define MKSOC(x) #x
-#define MAKESTRING(x) MKSOC(x)
-
-template<class T>
-class StaticClassType {
- public:
-
-  StaticClassType(const std::string &name, const std::string &description = "") {
-    // Notify when the static member is created
-    if (!description.empty()){
-      minifi::AgentDocs::putDescription(name,description);
-    }
-#ifdef MODULE_NAME
-    ClassLoader::getDefaultClassLoader().registerClass(name, std::unique_ptr<ObjectFactory>(new
DefautObjectFactory<T>(MAKESTRING(MODULE_NAME))));
-#else
-    ClassLoader::getDefaultClassLoader().registerClass(name, std::unique_ptr<ObjectFactory>(new
DefautObjectFactory<T>("minifi-system")));
-#endif
-  }
-};
-
-#define REGISTER_RESOURCE(CLASSNAME,DESC) \
-        static core::StaticClassType<CLASSNAME> \
-        CLASSNAME##_registrar( #CLASSNAME, DESC );
-
-#define REGISTER_RESOURCE_AS(CLASSNAME,NAME) \
-        static core::StaticClassType<CLASSNAME> \
-        CLASSNAME##_registrar( #NAME );
-
-}/* namespace core */
-} /* namespace minifi */
-} /* namespace nifi */
-} /* namespace apache */
-} /* namespace org */
-
-#endif /* LIBMINIFI_INCLUDE_CORE_RESOURCE_H_ */
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+#ifndef LIBMINIFI_INCLUDE_CORE_RESOURCE_H_
+#define LIBMINIFI_INCLUDE_CORE_RESOURCE_H_
+
+#include <memory>
+#include <string>
+
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN 1
+#endif
+
+#include "ClassLoader.h"
+#include "agent/agent_docs.h"
+
+namespace org {
+namespace apache {
+namespace nifi {
+namespace minifi {
+namespace core {
+
+#define MKSOC(x) #x
+#define MAKESTRING(x) MKSOC(x)
+
+template<class T>
+class StaticClassType {
+ public:
+  explicit StaticClassType(const std::string &name, const std::string &description
= "") {
+    // Notify when the static member is created
+    if (!description.empty()) {
+      minifi::AgentDocs::putDescription(name, description);
+    }
+#ifdef MODULE_NAME
+    ClassLoader::getDefaultClassLoader().registerClass(name, std::unique_ptr<ObjectFactory>(new
DefautObjectFactory<T>(MAKESTRING(MODULE_NAME))));
+#else
+    ClassLoader::getDefaultClassLoader().registerClass(name, std::unique_ptr<ObjectFactory>(new
DefautObjectFactory<T>("minifi-system")));
+#endif
+  }
+};
+
+#define REGISTER_RESOURCE(CLASSNAME, DESC) \
+        static core::StaticClassType<CLASSNAME> \
+        CLASSNAME##_registrar(#CLASSNAME, DESC);
+
+#define REGISTER_RESOURCE_AS(CLASSNAME, NAME) \
+        static core::StaticClassType<CLASSNAME> \
+        CLASSNAME##_registrar(#NAME);
+
+}/* namespace core */
+}  // namespace minifi
+}  // namespace nifi
+}  // namespace apache
+}  // namespace org

Review comment:
       Comment style fixed.

##########
File path: libminifi/include/core/TypedValues.h
##########
@@ -154,10 +159,10 @@ class DataSizeValue : public TransformableValue, public state::response::UInt64V
       : state::response::UInt64Value(value) {
   }
 
-  
+
 // Convert String to Integer
   template<typename T, typename std::enable_if<
-	  std::is_integral<T>::value>::type* = nullptr>
+    std::is_integral<T>::value>::type* = nullptr>

Review comment:
       ➡️ Added extra level of identation.

##########
File path: libminifi/include/core/WeakReference.h
##########
@@ -87,17 +85,15 @@ class ReferenceContainer {
   }
 
  protected:
-
   std::mutex mutex;
 
   std::vector<std::shared_ptr<WeakReference> > references;
-
 };
 
 }/* namespace core */
-} /* namespace minifi */
-} /* namespace nifi */
-} /* namespace apache */
-} /* namespace org */
+}  // namespace minifi
+}  // namespace nifi
+}  // namespace apache
+}  // namespace org
 

Review comment:
       Comment style fixed.

##########
File path: libminifi/include/core/controller/ControllerService.h
##########
@@ -146,12 +146,11 @@ class ControllerService : public ConfigurableComponent, public Connectable
{
     return false;
   }
 
-  void setLinkedControllerServices( const std::vector<std::shared_ptr<controller::ControllerService>
> &services ){
+  void setLinkedControllerServices(const std::vector<std::shared_ptr<controller::ControllerService>
> &services ) {

Review comment:
       Whitespace removed.

##########
File path: libminifi/include/core/controller/ControllerServiceProvider.h
##########
@@ -72,7 +74,7 @@ class ControllerServiceProvider : public CoreComponent, public ConfigurableCompo
    * @param id controller service identifier.
    * @return shared pointer to the controller service node.
    */
-  virtual std::shared_ptr<ControllerServiceNode> createControllerService(const std::string
&type,const std::string &longType, const std::string &id,
+  virtual std::shared_ptr<ControllerServiceNode> createControllerService(const std::string
&type, const std::string &longType, const std::string &id,
   bool firstTimeAdded) = 0;

Review comment:
       Lines joined.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message