nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #789: MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations
Date Tue, 02 Jun 2020 15:58:31 GMT

hunyadi-dev commented on a change in pull request #789:
URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r433990939



##########
File path: libminifi/include/c2/C2Callback.h
##########
@@ -18,17 +18,17 @@
 #ifndef LIBMINIFI_INCLUDE_C2_C2CALLBACK_H_
 #define LIBMINIFI_INCLUDE_C2_C2CALLBACK_H_
 
+#include <memory>
+
 
 #include "C2Agent.h"
 
 /**
  * Purpose: Provides a callback with very specific accesses
  */
 class C2Callback {
-
  public:
-  C2Callback(const std::shared_ptr<C2>)
-
+  explicit C2Callback(const std::shared_ptr<C2>)

Review comment:
       Resolved by removing `explicit` and adding `// NOLINT`. This file belongs to the 🚮
anyways.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message