From issues-return-96703-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon May 4 07:16:11 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BB70180608 for ; Mon, 4 May 2020 09:16:11 +0200 (CEST) Received: (qmail 13197 invoked by uid 500); 4 May 2020 07:16:10 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 13188 invoked by uid 99); 4 May 2020 07:16:10 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 07:16:10 +0000 From: =?utf-8?q?GitBox?= To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_davidvoit_commented_on_a_change_in_pull_re?= =?utf-8?q?quest_=234175=3A_NIFI-7307_-_Add_User_Metadata_support_to_the_Azu?= =?utf-8?q?re_Blob_Processors_+_LookupService?= Message-ID: <158857657035.26397.14308132242043581089.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 07:16:10 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: davidvoit commented on a change in pull request #4175: URL: https://github.com/apache/nifi/pull/4175#discussion_r419248566 ########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage.java ########## @@ -49,10 +54,38 @@ @SeeAlso({ ListAzureBlobStorage.class, PutAzureBlobStorage.class, DeleteAzureBlobStorage.class }) @InputRequirement(Requirement.INPUT_REQUIRED) @WritesAttributes({ - @WritesAttribute(attribute = "azure.length", description = "The length of the blob fetched") + @WritesAttribute(attribute = "azure.length", description = "The length of the blob fetched"), + @WritesAttribute(attribute = "azure.user.metadata.___", description = "If 'Write User Metadata' is set to 'True', the user defined metadata associated to the Blob object that is being listed " + + "will be written as part of the flowfile attributes") }) public class FetchAzureBlobStorage extends AbstractAzureBlobProcessor { + protected static final PropertyDescriptor WRITE_USER_METADATA = new PropertyDescriptor.Builder() Review comment: Did move it to AzureStorageUtils. I think this Utils class is there because List and Fetch are not extended from the same base class. But maybe Blob should be moved too? Anyway not something for this Pull request. Is this fine? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org