nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] pvillard31 commented on a change in pull request #4297: NIFI-7488 Listening Port property on HandleHttpRequest is not validated when Variable registry is used
Date Wed, 27 May 2020 03:25:13 GMT

pvillard31 commented on a change in pull request #4297:
URL: https://github.com/apache/nifi/pull/4297#discussion_r430307162



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/HandleHttpRequest.java
##########
@@ -321,6 +326,24 @@
         return Collections.singleton(REL_SUCCESS);
     }
 
+    @Override
+    protected Collection<ValidationResult> customValidate(final ValidationContext validationContext)
{
+        final List<ValidationResult> results = new ArrayList<>();
+
+        final Long port = validationContext.getProperty(PORT).evaluateAttributeExpressions().asLong();

Review comment:
       The validators, most of the time, won't do anything if expression language is used
to configure the property. I guess we could improve the validators based on the EL scope of
the property: if the scope is Variable Registry, we should be able to validate the property
even if EL is used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message