nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] esecules commented on a change in pull request #4265: NIFI-7434: Endpoint suffix property in AzureStorageAccount NIFI processors
Date Fri, 22 May 2020 18:40:11 GMT

esecules commented on a change in pull request #4265:
URL: https://github.com/apache/nifi/pull/4265#discussion_r429399731



##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/services/azure/storage/TestAzureStorageCredentialsControllerServiceLookup.java
##########
@@ -71,28 +73,32 @@ public void testLookupServiceA() {
         final AzureStorageCredentialsDetails storageCredentialsDetails = lookupService.getStorageCredentialsDetails(attributes);
         assertNotNull(storageCredentialsDetails);
         assertEquals("Account_A", storageCredentialsDetails.getStorageAccountName());
+        assertEquals("accountsuffix.core.windows.net", storageCredentialsDetails.getStorageSuffix());
     }
 
     @Test
     public void testLookupServiceB() {

Review comment:
       What is the default behavior when the suffix is null? in testLookupServiceB or a new
test can this test that we're maintaining the current behavior?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message