nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] hunyadi-dev commented on pull request #770: MINIFICPP-1203 - upgrade linter version to 1.4.4 and fix relevant linter errors
Date Wed, 20 May 2020 16:12:02 GMT

hunyadi-dev commented on pull request #770:
URL: https://github.com/apache/nifi-minifi-cpp/pull/770#issuecomment-631574636


   > I find the Google include ordering rules strange, but that's in CONTRIB.md, so I guess
we're better off enforcing them.
   > 
   > Thanks for the upgrade!
   
   Agreed on the rules being strange, I would much rather prefer the llvm standard too. I
could patch the linter for changing the order, but that would mean that we would need to apply
the same patch every time we want to upgrade the linter version (and that everyone developping
a code with linter assistance would need to apply the same patch to their own linter). I don't
think the change is worth the effort.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message