nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] davidvoit commented on a change in pull request #4175: NIFI-7307 - Add User Metadata support to the Azure Blob Processors + LookupService
Date Mon, 04 May 2020 07:16:10 GMT

davidvoit commented on a change in pull request #4175:
URL: https://github.com/apache/nifi/pull/4175#discussion_r419248566



##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/FetchAzureBlobStorage.java
##########
@@ -49,10 +54,38 @@
 @SeeAlso({ ListAzureBlobStorage.class, PutAzureBlobStorage.class, DeleteAzureBlobStorage.class
})
 @InputRequirement(Requirement.INPUT_REQUIRED)
 @WritesAttributes({
-    @WritesAttribute(attribute = "azure.length", description = "The length of the blob fetched")
+    @WritesAttribute(attribute = "azure.length", description = "The length of the blob fetched"),
+    @WritesAttribute(attribute = "azure.user.metadata.___", description = "If 'Write User
Metadata' is set to 'True', the user defined metadata associated to the Blob object that is
being listed " +
+        "will be written as part of the flowfile attributes")
 })
 public class FetchAzureBlobStorage extends AbstractAzureBlobProcessor {
 
+    protected static final PropertyDescriptor WRITE_USER_METADATA = new PropertyDescriptor.Builder()

Review comment:
       Did move it to AzureStorageUtils. I think this Utils class is there because List and
Fetch are not extended from the same base class. But maybe Blob should be moved too? Anyway
not something for this Pull request. Is this fine?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message