nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] turcsanyip commented on a change in pull request #4227: NIFI-7298: PutAzureDataLakeStorage tests.
Date Fri, 24 Apr 2020 09:57:37 GMT

turcsanyip commented on a change in pull request #4227:
URL: https://github.com/apache/nifi/pull/4227#discussion_r414450562



##########
File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureDataLakeStorage.java
##########
@@ -32,26 +49,223 @@
 
     @Before
     public void setUp() {
-        runner.setProperty(PutAzureDataLakeStorage.FILE, TEST_FILE_NAME);
+        runner.setProperty(PutAzureDataLakeStorage.DIRECTORY, DIRECTORY);
+        runner.setProperty(PutAzureDataLakeStorage.FILE, FILE_NAME);
+    }
+
+    @Test
+    public void testPutFileToExistingDirectory() throws Exception {
+        fileSystemClient.createDirectory(DIRECTORY);
+
+        runProcessor(FILE_DATA);
+
+        assertSuccess(DIRECTORY, FILE_NAME, FILE_DATA);
+    }
+
+    @Test
+    public void testPutFileToNonExistingDirectory() throws Exception {
+        runProcessor(FILE_DATA);
+
+        assertSuccess(DIRECTORY, FILE_NAME, FILE_DATA);
+    }
+
+    @Ignore
+    // DataLakeFileClient.getFileUrl() returns "dir1%2Fdir2%2Fdir3%2Fdir4" for "dir1/dir2/dir3/dir4"
+    // seems to be a bug in the Azure lib

Review comment:
       @MuazmaZ Thanks for the clarification. I modified the test and removed the `@Ignore`.
   
   @sjyang18 Do you have some test failures or it does not work at all?
   `mvn verify -Pintegration-tests` should work with `$HOME/azure-credentials.PROPERTIES`.
   There were some failing tests in `ITFetchAzureDataLakeStorage` and `ITDeleteAzureDataLakeStorage`.
I `@Ignore`-d them for now, they will be fixed soon in other jira tickets.
   Please send the error logs if it does not work for you now.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message