nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] turcsanyip commented on a change in pull request #4213: NIFI-7280 Use Atlas metadata namespace in Atlas Reporting Task
Date Thu, 16 Apr 2020 15:17:08 GMT
turcsanyip commented on a change in pull request #4213: NIFI-7280 Use Atlas metadata namespace
in Atlas Reporting Task
URL: https://github.com/apache/nifi/pull/4213#discussion_r409524153
 
 

 ##########
 File path: nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
 ##########
 @@ -333,30 +339,34 @@
     @Override
     protected List<PropertyDescriptor> getSupportedPropertyDescriptors() {
         final List<PropertyDescriptor> properties = new ArrayList<>();
+        // Basic atlas config
         properties.add(ATLAS_URLS);
-        properties.add(ATLAS_CONNECT_TIMEOUT);
-        properties.add(ATLAS_READ_TIMEOUT);
-        properties.add(ATLAS_AUTHN_METHOD);
-        properties.add(ATLAS_USER);
-        properties.add(ATLAS_PASSWORD);
-        properties.add(ATLAS_CONF_DIR);
-        properties.add(ATLAS_NIFI_URL);
         properties.add(ATLAS_DEFAULT_CLUSTER_NAME);
-        properties.add(NIFI_LINEAGE_STRATEGY);
-        properties.add(PROVENANCE_START_POSITION);
-        properties.add(PROVENANCE_BATCH_SIZE);
-        properties.add(SSL_CONTEXT_SERVICE);
+        properties.add(ATLAS_CONF_DIR);
+        properties.add(ATLAS_CONF_CREATE);
 
         // Following properties are required if ATLAS_CONF_CREATE is enabled.
         // Otherwise should be left blank.
-        properties.add(ATLAS_CONF_CREATE);
+        // Will be used by the atlas client by reading the values from the atlas config file
+        properties.add(ATLAS_CONNECT_TIMEOUT);
+        properties.add(ATLAS_READ_TIMEOUT);
+        properties.add(SSL_CONTEXT_SERVICE);
 
 Review comment:
   It is only used for Kafka at the moment. I would move it down, after Kafka Security Protocol.
Could you please also rename the property on the UI to "Kafka SSL Configuration" or something
like that? Please also fix the description and remove Atlas from it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message