nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] natural commented on a change in pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS
Date Mon, 13 Apr 2020 23:38:54 GMT
natural commented on a change in pull request #4207: NIFI-7203 Add ZooKeeper client and server
TLS
URL: https://github.com/apache/nifi/pull/4207#discussion_r407780342
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/state/server/ZooKeeperStateServer.java
 ##########
 @@ -136,7 +167,15 @@ private void startDistributed() throws IOException {
             quorumPeer.setInitLimit(quorumPeerConfig.getInitLimit());
             quorumPeer.setSyncLimit(quorumPeerConfig.getSyncLimit());
             quorumPeer.setQuorumVerifier(quorumPeerConfig.getQuorumVerifier(), false);
-            quorumPeer.setCnxnFactory(connectionFactory);
+
+            if (connectionFactory != null) {
+                quorumPeer.setCnxnFactory(connectionFactory);
+            }
+
+            if (secureConnectionFactory != null) {
+                quorumPeer.setCnxnFactory(secureConnectionFactory);
 
 Review comment:
   Did you mean `quorumPeer.setSecureCnxnFactory(secureConnectionFactory)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message