nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #748: MINIFICPP-1187 Implemented.
Date Wed, 01 Apr 2020 09:57:58 GMT
arpadboda commented on a change in pull request #748: MINIFICPP-1187 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/748#discussion_r401495968
 
 

 ##########
 File path: extensions/windows-event-log/Bookmark.cpp
 ##########
 @@ -48,7 +48,7 @@ Bookmark::Bookmark(const std::wstring& channel, const std::wstring&
query, const
   }
   const utils::ScopeGuard guard_hEventResults([hEventResults]() { EvtClose(hEventResults);
});
 
-  if (!EvtSeek(hEventResults, 0, 0, 0, EvtSeekRelativeToLast)) {
+  if (!EvtSeek(hEventResults, 0, 0, 0, processOldEvents? EvtSeekRelativeToFirst : EvtSeekRelativeToLast))
{
 
 Review comment:
   What happens in case the property is true and the server restarted? (It processed some
events before, so not all event should be reprocessed)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message