nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting
Date Thu, 12 Mar 2020 16:36:40 GMT
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection
and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391746461
 
 

 ##########
 File path: libminifi/src/c2/C2Agent.cpp
 ##########
 @@ -342,6 +342,31 @@ void C2Agent::serializeMetrics(C2Payload &metric_payload, const
std::string &nam
   }
 }
 
+/*
+void C2Agent::serializeMetrics(C2Payload &metric_payload, const std::string &name,
const std::vector<state::response::SerializedResponseNode> &metrics, bool is_container,
bool is_collapsible) {
 
 Review comment:
   Committed that accidentally. Removed the comments in latest commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message