nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection and reporting
Date Thu, 12 Mar 2020 14:45:02 GMT
msharee9 commented on a change in pull request #743: Minificpp 1169 - Simplify C2 metrics collection
and reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/743#discussion_r391670955
 
 

 ##########
 File path: nanofi/include/cxx/C2CallbackAgent.h
 ##########
 @@ -47,7 +47,10 @@ class C2CallbackAgent : public c2::C2Agent {
 
  public:
 
-  explicit C2CallbackAgent(const std::shared_ptr<core::controller::ControllerServiceProvider>
&controller, const std::shared_ptr<state::StateMonitor> &updateSink, const std::shared_ptr<Configure>
&configure);
+  explicit C2CallbackAgent(const std::shared_ptr<core::controller::ControllerServiceProvider>
&controller,
 
 Review comment:
   This class is not used anywhere in the code today. It will be removed later when nanofi
c2 work gets completed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message