nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…
Date Tue, 10 Mar 2020 13:19:20 GMT
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller
service and component st…
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r390305696
 
 

 ##########
 File path: libminifi/include/core/ProcessContext.h
 ##########
 @@ -193,6 +216,61 @@ class ProcessContext : public controller::ControllerServiceLookup, public
core::
     return controller_service_provider_->getControllerServiceName(identifier);
   }
 
+  static constexpr char const* DefaultStateManagerProviderName = "defaultstatemanagerprovider";
 
 Review comment:
   Sorry for coming through as offensive. I lack a lot of contextual knowledge and at the
time of writing the original comment, I knew even less.
   
   I maintain my standpoint that there is most likely too much abstraction but now I understand
that changing this would require redesign of significant parts of the project and it is harmful
to do so without serious thought.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message