From issues-return-92568-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Feb 21 15:43:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 11144180675 for ; Fri, 21 Feb 2020 16:43:32 +0100 (CET) Received: (qmail 66809 invoked by uid 500); 21 Feb 2020 15:43:32 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 66791 invoked by uid 99); 21 Feb 2020 15:43:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Feb 2020 15:43:32 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class Message-ID: <158229981232.13901.1933599572859995678.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 21 Feb 2020 15:43:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpadboda commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382647644 ########## File path: libminifi/include/utils/HTTPClient.h ########## @@ -219,16 +232,15 @@ class HTTPRequestResponse { } if (len > size * nmemb) len = size * nmemb; - auto strr = std::string(ptr,len); memcpy(data, ptr, len); callback->pos += len; callback->ptr->seek(callback->getPos()); return len; } - } else { - return 0x10000000; + return 0; Review comment: nitpicking: this is is overindented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services