From issues-return-92437-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Thu Feb 20 02:19:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3CBAE180658 for ; Thu, 20 Feb 2020 03:19:53 +0100 (CET) Received: (qmail 12357 invoked by uid 500); 20 Feb 2020 02:19:52 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 12348 invoked by uid 99); 20 Feb 2020 02:19:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 Feb 2020 02:19:52 +0000 From: GitBox To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_alopresto_commented_on_a_change_in_pull?= =?utf-8?q?_request_=234062=3A_NIFI-7030_Add_Kerberos_principal_and_passwo?= =?utf-8?q?rd_properties_to_Solr_proc=E2=80=A6?= Message-ID: <158216519245.18800.16305144595590408398.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 20 Feb 2020 02:19:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit alopresto commented on a change in pull request #4062: NIFI-7030 Add Kerberos principal and password properties to Solr proc… URL: https://github.com/apache/nifi/pull/4062#discussion_r381675566 ########## File path: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/src/main/java/org/apache/nifi/processors/solr/SolrUtils.java ########## @@ -149,6 +151,25 @@ .required(false) .build(); + public static final PropertyDescriptor KERBEROS_PRINCIPAL = new PropertyDescriptor.Builder() + .name("Kerberos Principal") + .description("The principal to use when specifying the principal and password directly in the processor for authenticating to Solr via Kerberos.") + .required(false) + .addValidator(StandardValidators.NON_EMPTY_VALIDATOR) + .addValidator(StandardValidators.createAttributeExpressionLanguageValidator(AttributeExpression.ResultType.STRING)) + .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY) + .build(); + + public static final PropertyDescriptor KERBEROS_PASSWORD = new PropertyDescriptor.Builder() + .name("Kerberos Password") Review comment: Minor issue but I would use `.name("kerberos-password")` and `.displayName("Kerberos Password")` here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services