From issues-return-91766-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon Feb 10 15:57:47 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0AA2A180663 for ; Mon, 10 Feb 2020 16:57:46 +0100 (CET) Received: (qmail 77074 invoked by uid 500); 10 Feb 2020 15:57:46 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 77047 invoked by uid 99); 10 Feb 2020 15:57:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Feb 2020 15:57:46 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues Message-ID: <158135026611.19994.4404399551876580753.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 10 Feb 2020 15:57:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bakaid commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r377143374 ########## File path: libminifi/src/io/tls/TLSSocket.cpp ########## @@ -170,22 +174,19 @@ void TLSSocket::closeStream() { * @param listeners number of listeners in the queue */ TLSSocket::TLSSocket(const std::shared_ptr &context, const std::string &hostname, const uint16_t port, const uint16_t listeners) - : Socket(context, hostname, port, listeners), - ssl_(0) { + : Socket(context, hostname, port, listeners) { logger_ = logging::LoggerFactory::getLogger(); context_ = context; } TLSSocket::TLSSocket(const std::shared_ptr &context, const std::string &hostname, const uint16_t port) - : Socket(context, hostname, port, 0), - ssl_(0) { + : Socket(context, hostname, port, 0) { logger_ = logging::LoggerFactory::getLogger(); context_ = context; } -TLSSocket::TLSSocket(const TLSSocket &&d) - : Socket(std::move(d)), - ssl_(0) { +TLSSocket::TLSSocket(TLSSocket &&d) noexcept Review comment: I think this implementation is wrong (it was wrong before this PR). TLSSocket has a bunch of data members that are ignored by this move constructor, among them an std::map, whose move constructor is not noexcept, as far as I know, so TLSSocket's can't be either. Not to mention that the single data member it does not ignore is copied, but since that's a shared_ptr, that part might have actually worked. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services