From issues-return-91718-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Feb 7 20:57:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B7E2718060E for ; Fri, 7 Feb 2020 21:57:27 +0100 (CET) Received: (qmail 18620 invoked by uid 500); 7 Feb 2020 20:57:27 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 18611 invoked by uid 99); 7 Feb 2020 20:57:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2020 20:57:27 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented. Message-ID: <158110904692.10040.14084868265628427361.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 07 Feb 2020 20:57:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376595029 ########## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ########## @@ -226,20 +229,32 @@ void ConsumeWindowsEventLog::onSchedule(const std::shared_ptrgetProperty(OutputFormat.getName(), mode); + + writeXML_ = (mode == Both || mode == XML); + + writePlainText_ = (mode == Both || mode == Plaintext); + + if (writeXML_) { + char systemDir[MAX_PATH]; + if (GetSystemDirectory(systemDir, sizeof(systemDir))) { Review comment: It is not necessary since minificpp uses Multi-Byte Character Set and macro GetSystemDirectory resolved as GetSystemDirectoryA. In general, if a concern that there is a possibility to accidentally use Unicode instead of Multi-Byte Character Set (or vice versa) - it is not possible because of compilation error. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services