From issues-return-91714-archive-asf-public=cust-asf.ponee.io@nifi.apache.org  Fri Feb  7 20:36:26 2020
Return-Path: <issues-return-91714-archive-asf-public=cust-asf.ponee.io@nifi.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id 3F65518060E
	for <archive-asf-public@cust-asf.ponee.io>; Fri,  7 Feb 2020 21:36:26 +0100 (CET)
Received: (qmail 2360 invoked by uid 500); 7 Feb 2020 20:36:25 -0000
Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@nifi.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@nifi.apache.org>
List-Post: <mailto:issues@nifi.apache.org>
List-Id: <issues.nifi.apache.org>
Reply-To: dev@nifi.apache.org
Delivered-To: mailing list issues@nifi.apache.org
Received: (qmail 2351 invoked by uid 99); 7 Feb 2020 20:36:25 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2020 20:36:25 +0000
From: GitBox <git@apache.org>
To: issues@nifi.apache.org
Subject: [GitHub] [nifi-minifi-cpp] am-c-p-p commented on a change in pull request
 #728: MINIFICPP-1147 Implemented.
Message-ID: <158110778549.2974.11665757849881576277.gitbox@gitbox.apache.org>
References: <infra.728.MDExOlB1bGxSZXF1ZXN0MzcyMTMxOTY2.gitbox@gitbox.apache.org>
In-Reply-To: <infra.728.MDExOlB1bGxSZXF1ZXN0MzcyMTMxOTY2.gitbox@gitbox.apache.org>
Date: Fri, 07 Feb 2020 20:36:25 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

am-c-p-p commented on a change in pull request #728: MINIFICPP-1147 Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376595029
 
 

 ##########
 File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
 ##########
 @@ -226,20 +229,32 @@ void ConsumeWindowsEventLog::onSchedule(const std::shared_ptr<core::ProcessConte
     }
   }
 
+  std::string mode;
+  context->getProperty(OutputFormat.getName(), mode);
+
+  writeXML_ = (mode == Both || mode == XML);
+
+  writePlainText_ = (mode == Both || mode == Plaintext);
+
+  if (writeXML_) {
+    char systemDir[MAX_PATH];
+    if (GetSystemDirectory(systemDir, sizeof(systemDir))) {
 
 Review comment:
   It is not necessary since minificpp uses Multi-Byte Character Set and macro GetSystemDirectory resolved as GetSystemDirectoryA. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services