From issues-return-91396-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon Feb 3 16:10:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BFFD9180680 for ; Mon, 3 Feb 2020 17:10:25 +0100 (CET) Received: (qmail 83951 invoked by uid 500); 3 Feb 2020 16:10:25 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 83698 invoked by uid 99); 3 Feb 2020 16:10:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 16:10:24 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues Message-ID: <158074622463.17339.7723421107324297124.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 16:10:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpadboda commented on a change in pull request #713: MINIFICPP-1119 unify win/posix sockets + clean up issues URL: https://github.com/apache/nifi-minifi-cpp/pull/713#discussion_r374142976 ########## File path: libminifi/src/io/StreamFactory.cpp ########## @@ -76,9 +77,8 @@ class SocketCreator : public AbstractStreamFactory { std::unique_ptr createSecureSocket(const std::string &host, const uint16_t port, const std::shared_ptr &ssl_service) { #ifdef OPENSSL_SUPPORT if (ssl_service != nullptr) { - auto ptr = std::make_shared(configuration_, ssl_service); - TLSSocket *socket = new TLSSocket(ptr, host, port); - return std::unique_ptr(socket); + auto context = std::make_shared(configuration_, ssl_service); + return utils::make_unique(context, host, port); } else { Review comment: Nitpicking: no need for the else branch here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services