From issues-return-91373-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon Feb 3 11:43:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7C83B180647 for ; Mon, 3 Feb 2020 12:43:53 +0100 (CET) Received: (qmail 5655 invoked by uid 500); 3 Feb 2020 11:43:52 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 5646 invoked by uid 99); 3 Feb 2020 11:43:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 11:43:52 +0000 From: GitBox To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_arpadboda_commented_on_a_cha?= =?utf-8?q?nge_in_pull_request_=23721=3A_MINIFICPP-1135_-_Add_a_watchdog_t?= =?utf-8?q?o_schedulingAgent_to_warn_in_case_of=E2=80=A6?= Message-ID: <158073023271.18619.15057308022451314815.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 11:43:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpadboda commented on a change in pull request #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of… URL: https://github.com/apache/nifi-minifi-cpp/pull/721#discussion_r374057815 ########## File path: libminifi/src/Configure.cpp ########## @@ -28,6 +28,7 @@ const char *Configure::nifi_flow_configuration_file = "nifi.flow.configuration.f const char *Configure::nifi_flow_configuration_file_exit_failure = "nifi.flow.configuration.file.exit.onfailure"; const char *Configure::nifi_flow_configuration_file_backup_update = "nifi.flow.configuration.backup.on.update"; const char *Configure::nifi_flow_engine_threads = "nifi.flow.engine.threads"; +const char *Configure::nifi_flow_engine_alert_time = "nifi.flow.engine.alert.time"; Review comment: We could, but none of our current settings contain unit in the name, so I would go for being consistent with what we have. In the longer term I would like to have a documentation that lists all the config params we have with units, description, etc. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services