nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (Jira)" <j...@apache.org>
Subject [jira] [Commented] (NIFI-7109) Unit tests should be able to determine if item validator was called
Date Wed, 12 Feb 2020 16:26:00 GMT

    [ https://issues.apache.org/jira/browse/NIFI-7109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17035494#comment-17035494
] 

ASF subversion and git services commented on NIFI-7109:
-------------------------------------------------------

Commit 6e8f10c4f66f0167b9a43c91c549f1d36208d9cc in nifi's branch refs/heads/master from Otto
Fowler
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=6e8f10c ]

NIFI-7109 Unit tests should be able to determine if item validator was called
- Create a mock Validator to track count of calls to validate().
We cannot use Mockito for this, because it can't mock all the
StandardValidators

refactor based on review comments

fix naming in comments

moved to main based on review

Signed-off-by: Matthew Burgess <mattyb149@apache.org>

This closes #4043


> Unit tests should be able to determine if item validator was called
> -------------------------------------------------------------------
>
>                 Key: NIFI-7109
>                 URL: https://issues.apache.org/jira/browse/NIFI-7109
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Otto Fowler
>            Assignee: Otto Fowler
>            Priority: Major
>          Time Spent: 2h 20m
>  Remaining Estimate: 0h
>
> In cases where there is a 'per item' validator provided for a list type validator, we
cannot tell if an item is invalid because it failed the outer validator or the passed validator.
> We should be able to do this, with a mock, delighting validator that counts the calls.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Mime
View raw message