nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class
Date Fri, 21 Feb 2020 15:43:32 GMT
arpadboda commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze
and refactor class
URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382647644
 
 

 ##########
 File path: libminifi/include/utils/HTTPClient.h
 ##########
 @@ -219,16 +232,15 @@ class HTTPRequestResponse {
         }
         if (len > size * nmemb)
           len = size * nmemb;
-        auto strr = std::string(ptr,len);
         memcpy(data, ptr, len);
         callback->pos += len;
         callback->ptr->seek(callback->getPos());
         return len;
       }
-    } else {
-      return 0x10000000;
+      return 0;
 
 Review comment:
   nitpicking: this is is overindented. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message