nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.
Date Thu, 13 Feb 2020 09:59:56 GMT
bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2
heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378754450
 
 

 ##########
 File path: libminifi/src/c2/C2Agent.cpp
 ##########
 @@ -539,9 +563,9 @@ void C2Agent::handle_describe(const C2ContentResponse &resp) {
   } else if (resp.name == "manifest") {
     auto keys = configuration_->getConfiguredKeys();
     C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
-    response.setLabel("configuration_options");
+    response.setLabel("configurationOptions");
 
 Review comment:
   "jstack" also utilizes this label, although unchanged (still "configuration_options"),
but fills it with different information. This does not look right.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message