nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] ottobackwards commented on a change in pull request #4043: NIFI-7109 Unit tests should be able to determine if item validator wa…
Date Mon, 10 Feb 2020 18:25:26 GMT
ottobackwards commented on a change in pull request #4043: NIFI-7109 Unit tests should be able
to determine if item validator wa…
URL: https://github.com/apache/nifi/pull/4043#discussion_r377236590
 
 

 ##########
 File path: nifi-commons/nifi-utils/src/test/java/org/apache/nifi/util/validator/TestMockValidator.java
 ##########
 @@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.util.validator;
+
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+
+/**
+ * TestMockValidator wraps a {@class Validator} and provides statistics on it's interactions.
+ * Because many of the {@class Validator} instances returned from {@class StandardValidator
}
+ * are not mockable with with mockito, this is required to know, when running a test, if
a
+ * {@class Validator} was in fact called, for example.
+ */
+public class TestMockValidator implements Validator {
 
 Review comment:
   I could try it in mocks and "see" what happens, then rebase/force push if it works, how
does that sound?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message