nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime
Date Thu, 06 Feb 2020 16:38:28 GMT
szaszm commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo
lifetime
URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375947710
 
 

 ##########
 File path: libminifi/src/io/win/ClientSocket.cpp
 ##########
 @@ -242,11 +237,17 @@ int16_t Socket::initialize() {
   hints.ai_protocol = 0; /* any protocol */
 
   int errcode = getaddrinfo(requested_hostname_.c_str(), 0, &hints, &addr_info_);
 
 Review comment:
   The value is accessed by `createConnection` as a data member and I didn't want to risk
breaking anything during this bugfix by changing the signature to take an additional argument.
   
   I'd prefer to later rewrite the whole class, that will most likely eliminate the need to
pass the result of `getaddrinfo` to the function.
   
   I can do additional investigation about the required effort if you insist on this change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message