nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo lifetime
Date Thu, 06 Feb 2020 16:30:07 GMT
arpadboda commented on a change in pull request #727: MINIFICPP-1148 ClientSocket: fix addrinfo
lifetime
URL: https://github.com/apache/nifi-minifi-cpp/pull/727#discussion_r375939226
 
 

 ##########
 File path: libminifi/src/io/win/ClientSocket.cpp
 ##########
 @@ -242,11 +237,17 @@ int16_t Socket::initialize() {
   hints.ai_protocol = 0; /* any protocol */
 
   int errcode = getaddrinfo(requested_hostname_.c_str(), 0, &hints, &addr_info_);
 
 Review comment:
   That's great, but in that case I think it just needs to be a local variable and not a member.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message