nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #710: MINIFICPP - 1110, 1111 - PublishKafka, OPC processors should config and
Date Thu, 06 Feb 2020 15:28:20 GMT
arpadboda commented on a change in pull request #710: MINIFICPP - 1110,1111 - PublishKafka,
OPC processors should config and
URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375902215
 
 

 ##########
 File path: libminifi/include/core/state/Value.h
 ##########
 @@ -87,6 +88,15 @@ class Value {
     type_id = std::type_index(typeid(T));
   }
 
+  virtual bool getValue(uint32_t &ref) {
+    const auto negative = string_value.find_first_of('-') != std::string::npos;
 
 Review comment:
   In my opinion the variable just decreases readability here, but this is really minor, I'm
fine with the current way as well. 
   
   Although it's simply wrong. 
   It's going to fail in case the '-' char is after the digits (like "3-"), which std::stoull
handles. 
   Either let it go or go strict and apply isdigit check for all.
   
   I will create a Jira for this, should be done in scope of a separate PR. 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message