nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle java.sql.Array Types in normaleValue method
Date Tue, 04 Feb 2020 20:43:55 GMT
pvillard31 commented on a change in pull request #4034: NIFI-7095: ResetSetRecordSet: handle
java.sql.Array Types in normaleValue method
URL: https://github.com/apache/nifi/pull/4034#discussion_r374911915
 
 

 ##########
 File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
 ##########
 @@ -128,7 +128,7 @@ protected Record createRecord(final ResultSet rs) throws SQLException
{
     }
 
     @SuppressWarnings("rawtypes")
-    private Object normalizeValue(final Object value) {
+    private Object normalizeValue(final Object value) throws SQLException {
 
 Review comment:
   Is this change necessary at all?
   ```suggestion
       private Object normalizeValue(final Object value) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message