From issues-return-91286-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Jan 31 10:38:20 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A992C18037A for ; Fri, 31 Jan 2020 11:38:19 +0100 (CET) Received: (qmail 12822 invoked by uid 500); 31 Jan 2020 10:38:19 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 12812 invoked by uid 99); 31 Jan 2020 10:38:19 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Jan 2020 10:38:19 +0000 From: GitBox To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi-minifi-cpp=5D_bakaid_commented_on_issue_?= =?utf-8?q?=23721=3A_MINIFICPP-1135_-_Add_a_watchdog_to_schedulingAgent_to?= =?utf-8?q?_warn_in_case_of=E2=80=A6?= Message-ID: <158046709891.27087.1794477754354276912.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 31 Jan 2020 10:38:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bakaid commented on issue #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of… URL: https://github.com/apache/nifi-minifi-cpp/pull/721#issuecomment-580680863 @arpadboda Ran tests, functionality seems OK. I have concerns about the hardcoded value for the warning time. It may be perfectly valid to have onTriggers running for more than 5 seconds, especially if there are periodic commits. The general case is that it is probably not good to have an onTrigger running for more than 5 seconds, so it is a good thing to warn developers and flow creators about it, but in case it is an accepted thing, I definitely don't want a warn level log about it every second. I propose adding a configuration property to the effect of `nifi.scheduler.ontrigger.warning.time` with a default value of `5 sec` and using that instead of the hardcoded value. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services