nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] m-hogue edited a comment on issue #3930: NIFI-6851: Added FlowFileAcquisitionMethod to fetch/receive methods i…
Date Tue, 07 Jan 2020 21:20:02 GMT
m-hogue edited a comment on issue #3930: NIFI-6851: Added FlowFileAcquisitionMethod to fetch/receive
methods i…
URL: https://github.com/apache/nifi/pull/3930#issuecomment-571773726
 
 
   > As it is, it stores a mapping of FlowFileAcquisitionMethod to a number
   
   @markap14 : I see what you're saying. This behavior was actually copied from the existing
implementation for event types, which i believe has this same problem:
   
   https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/EventIdFirstSchemaRecordWriter.java#L89
   
   This means that the event type map and the acquisition type map both need to be serialized
in the event header and read at deserialization time to know how it was serialized. As it
is, a list of enum names is serialized in the order of the enum. So if the ordering of enums
changes between versions, this breaks. Correct? If so, i can work on fixing that.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message