From issues-return-89211-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Tue Dec 17 03:16:29 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AC355180660 for ; Tue, 17 Dec 2019 04:16:29 +0100 (CET) Received: (qmail 93527 invoked by uid 500); 17 Dec 2019 03:16:28 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 93517 invoked by uid 99); 17 Dec 2019 03:16:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2019 03:16:27 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi] patricker commented on a change in pull request #3763: NIFI-6684 Add more property to Hive3ConnectionPool Message-ID: <157655258752.4489.6782139179055102765.gitbox@gitbox.apache.org> Date: Tue, 17 Dec 2019 03:16:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit patricker commented on a change in pull request #3763: NIFI-6684 Add more property to Hive3ConnectionPool URL: https://github.com/apache/nifi/pull/3763#discussion_r358579051 ########## File path: nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/dbcp/hive/Hive3ConnectionPool.java ########## @@ -178,6 +278,12 @@ protected void init(final ControllerServiceInitializationContext context) { props.add(MAX_WAIT_TIME); props.add(MAX_TOTAL_CONNECTIONS); props.add(VALIDATION_QUERY); + props.add(MIN_IDLE); Review comment: Hey @mattyb149. Your right, my bad. It's not much of an excuse on my end, but basically I compared this to the previous ticket where properties were added, saw that it was a copy/paste from that previous addition to the DBCP properties, and now we have properties in both that say they allow EL but don't actually.... https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java#L312 Is the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services