nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on issue #690: MINIFICPP-1026 - Added base64 encoder-decoder to StringUtils
Date Thu, 05 Dec 2019 16:26:04 GMT
arpadboda commented on issue #690: MINIFICPP-1026 - Added base64 encoder-decoder to StringUtils
URL: https://github.com/apache/nifi-minifi-cpp/pull/690#issuecomment-562204471
 
 
   > > ```
   > > * keep in mind that even if we used some base64 implementation from a third party
we would still need
   > >   
   > >   * all the StringUtils functions that wrap it, except the encoding/decoding
function
   > >   * all the tests
   > > ```
   > 
   > This is debatable but a tested third party impl if one exists can be trusted. This
is a lot of code with the potential for bugs. In your case you've written a lot of code, so
I don't want to demean it but the code for an external third party with StringUtils seems
much less risky with much lower tests -- unless we simply can't find a third party impl. What
you say about cURL is a valid point. Did you attempt to find a third party example? If not
I can take a look -- there may be other string related libraries that provide this and some
of what we do with StringUtils..
   
   Partly agree, partly disagree. 
   For eg. boost does a lot of thing. But it is a huge dependency, heavily increases build
time, etc. 
   For most of the 3rd parties, in case we don't want to flood our own repo, we need to maintain
cmake files, sometimes update dependencies, maybe edit bootstrap. These are also costs and
they apply time to time when something needs to be updated. There are cases when these costs
are definitely justified by the functionality the library introduces (just as opencv, curl,
kafka, mqtt, etc...), but in case of some quite simple string util functionality the longer
terms costs of having the dependency might show exceed the costs of doing it right, once.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message