From issues-return-88102-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Nov 15 01:05:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 43023180607 for ; Fri, 15 Nov 2019 02:05:36 +0100 (CET) Received: (qmail 18409 invoked by uid 500); 15 Nov 2019 01:05:35 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 18400 invoked by uid 99); 15 Nov 2019 01:05:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Nov 2019 01:05:35 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] asdaraujo commented on a change in pull request #668: MINIFICPP-1072 - Fixed temporary path for GetFileTests on Windows Message-ID: <157377993542.24777.16814579684139730992.gitbox@gitbox.apache.org> Date: Fri, 15 Nov 2019 01:05:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit asdaraujo commented on a change in pull request #668: MINIFICPP-1072 - Fixed temporary path for GetFileTests on Windows URL: https://github.com/apache/nifi-minifi-cpp/pull/668#discussion_r346622172 ########## File path: extensions/standard-processors/tests/unit/GetFileTests.cpp ########## @@ -52,7 +52,7 @@ TEST_CASE("GetFile: MaxSize", "[getFileFifo]") { // NOLINT std::string in_file = temp_path + utils::file::FileUtils::get_separator() + "testfifo"; // Define test input file - std::string hidden_in_file(in_dir); + std::string hidden_in_file(temp_path); Review comment: Done! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services