From issues-return-87888-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Fri Nov 8 14:44:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E54C0180661 for ; Fri, 8 Nov 2019 15:44:30 +0100 (CET) Received: (qmail 15132 invoked by uid 500); 8 Nov 2019 14:44:30 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 14899 invoked by uid 99); 8 Nov 2019 14:44:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Nov 2019 14:44:29 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #677: MINIFICPP-1065 - Fix UUID generation uniqueness and thread safety Message-ID: <157322426944.5948.5865374588620203000.gitbox@gitbox.apache.org> Date: Fri, 08 Nov 2019 14:44:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpadboda commented on a change in pull request #677: MINIFICPP-1065 - Fix UUID generation uniqueness and thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/677#discussion_r344200004 ########## File path: libminifi/src/utils/Id.cpp ########## @@ -174,7 +237,7 @@ void IdGenerator::initialize(const std::shared_ptr & properties) { implementation_ = UUID_TIME_IMPL; if (properties->get("uid.implementation", implementation_str)) { std::transform(implementation_str.begin(), implementation_str.end(), implementation_str.begin(), ::tolower); - if ("random" == implementation_str) { + if ("random" == implementation_str || "windows_random" == implementation_str) { Review comment: I would prefer to have these constants defined somewhere in the header. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services