From issues-return-87764-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Nov 6 15:16:59 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B1855180661 for ; Wed, 6 Nov 2019 16:16:58 +0100 (CET) Received: (qmail 61482 invoked by uid 500); 6 Nov 2019 15:16:58 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 61448 invoked by uid 99); 6 Nov 2019 15:16:58 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2019 15:16:58 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #675: MINIFICPP-1063 - Log directory location should be configurable Message-ID: <157305341789.28461.14826606310555855179.gitbox@gitbox.apache.org> Date: Wed, 06 Nov 2019 15:16:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpadboda commented on a change in pull request #675: MINIFICPP-1063 - Log directory location should be configurable URL: https://github.com/apache/nifi-minifi-cpp/pull/675#discussion_r343151850 ########## File path: libminifi/src/core/logging/LoggerConfiguration.cpp ########## @@ -135,31 +135,34 @@ std::shared_ptr LoggerConfiguration::initialize_names if ("nullappender" == appender_type || "null appender" == appender_type || "null" == appender_type) { sink_map[appender_name] = std::make_shared(); } else if ("rollingappender" == appender_type || "rolling appender" == appender_type || "rolling" == appender_type) { - std::string file_name = ""; + std::string file_name; if (!logger_properties->get(appender_key + ".file_name", file_name)) { file_name = "minifi-app.log"; } - std::string directory = ""; - directory = logger_properties->getHome(); - if (!directory.empty()) { - // Create the log directory if needed - directory += "/logs"; + std::string directory; + if (!logger_properties->get(appender_key + ".directory", directory)) { + // The below part assumes logger_properties->getHome() is existing + // Cause minifiHome must be set at MiNiFiMain.cpp? + directory = logger_properties->getHome() + "/logs"; + } + #ifdef WIN32 struct _stat logDirStat; if (_stat(directory.c_str(), &logDirStat) != 0) { if (_mkdir(directory.c_str()) == -1) { + std::cerr << directory << " cannot be created due to " << strerror(errno) << '\n'; exit(1); } #else struct stat logDirStat; if (stat(directory.c_str(), &logDirStat) != 0 || !S_ISDIR(logDirStat.st_mode)) { if (mkdir(directory.c_str(), 0777) == -1) { + std::cerr << directory << " cannot be created due to " << strerror(errno) << '\n'; exit(1); } #endif } - file_name = directory + "/" + file_name; - } + file_name = directory + "/" + file_name; Review comment: Please use _get_separator_ from _FileUtils_, this would break logging on Win! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services