From issues-return-87745-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Nov 6 13:49:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 82698180651 for ; Wed, 6 Nov 2019 14:49:23 +0100 (CET) Received: (qmail 80828 invoked by uid 500); 6 Nov 2019 13:49:22 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 80819 invoked by uid 99); 6 Nov 2019 13:49:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Nov 2019 13:49:22 +0000 From: GitBox To: issues@nifi.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bnifi=5D_mattyb149_commented_on_a_change_in_pull?= =?utf-8?q?_request_=233815=3A_NIFI-6771_=3A_Added_fix_to_support_Oracle_B?= =?utf-8?q?inary_float_and_Binary_doubl=E2=80=A6?= Message-ID: <157304816279.1594.16983384964536838492.gitbox@gitbox.apache.org> Date: Wed, 06 Nov 2019 13:49:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mattyb149 commented on a change in pull request #3815: NIFI-6771 : Added fix to support Oracle Binary float and Binary doubl… URL: https://github.com/apache/nifi/pull/3815#discussion_r343103206 ########## File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcCommon.java ########## @@ -345,8 +345,11 @@ public static long convertToAvroStream(final ResultSet rs, final OutputStream ou byte[] bytes = rs.getBytes(i); ByteBuffer bb = ByteBuffer.wrap(bytes); rec.put(i - 1, bb); - - } else if (value instanceof Byte) { + } else if (javaSqlType == 100) { // Handle Oracle BINARY_FLOAT data type Review comment: The changes have tab characters rather than spaces, which causes a CheckStyle violation. I will convert them before merging ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services