From issues-return-87566-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Mon Nov 4 02:37:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0DEC8180621 for ; Mon, 4 Nov 2019 03:37:34 +0100 (CET) Received: (qmail 83085 invoked by uid 500); 4 Nov 2019 02:37:33 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 82928 invoked by uid 99); 4 Nov 2019 02:37:33 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 Nov 2019 02:37:33 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi] not-for-me commented on a change in pull request #3511: NIFI-6175 Spark Livy - Improving Livy Message-ID: <157283505294.15853.10065170694787673232.gitbox@gitbox.apache.org> Date: Mon, 04 Nov 2019 02:37:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit not-for-me commented on a change in pull request #3511: NIFI-6175 Spark Livy - Improving Livy URL: https://github.com/apache/nifi/pull/3511#discussion_r341888854 ########## File path: nifi-nar-bundles/nifi-spark-bundle/nifi-livy-controller-service-api/src/main/java/org/apache/nifi/controller/api/livy/LivyBatchService.java ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.controller.api.livy; + +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.controller.api.livy.exception.SessionManagerException; + +public interface LivyBatchService extends ControllerService { + String APPLICATION_JSON = "application/json"; + String USER = "nifi"; + + LivyBatch getBatchSession(Integer batchid) throws SessionManagerException; Review comment: How about renaming `batchid` as a camelCase? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services