nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #683: MINIFICPP-1087 - Proper handling of errors during onSchedule calls
Date Thu, 28 Nov 2019 15:44:26 GMT
bakaid commented on a change in pull request #683: MINIFICPP-1087 - Proper handling of errors
during onSchedule calls
URL: https://github.com/apache/nifi-minifi-cpp/pull/683#discussion_r351844340
 
 

 ##########
 File path: libminifi/test/integration/OnScheduleErrorHandlingTests.cpp
 ##########
 @@ -0,0 +1,70 @@
+/**
+ * @file GenerateFlowFile.h
+ * GenerateFlowFile class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#undef NDEBUG
+#include <cassert>
+#include "IntegrationBase.h"
+#include "core/logging/Logger.h"
+#include "../TestBase.h"
+#include "../KamikazeProcessor.h"
+
+class OnScheduleErrorHandlingTests : public IntegrationBase {
+ public:
+  virtual void runAssertions() {
+    std::string logs = LogTestController::getInstance().log_output.str();
+    size_t pos = 0;
+    unsigned int occurances = 0;
+    do {
+      pos = logs.find(minifi::processors::KamikazeProcessor::OnScheduleExceptionStr, pos);
+      if (pos != std::string::npos) {
+        pos = logs.find(minifi::processors::KamikazeProcessor::OnUnScheduleLogStr, pos);
+        if (pos != std::string::npos) {
+          occurances++;
+        }
+      }
+    } while (pos != std::string::npos && pos < logs.length());
 
 Review comment:
   If `std::string::find` returned `pos >= logs.length()` without it being `std::string::npos`
I would be scared out of my mind.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message