nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #677: MINIFICPP-1065 - Fix UUID generation uniqueness and thread safety
Date Fri, 08 Nov 2019 14:44:29 GMT
arpadboda commented on a change in pull request #677: MINIFICPP-1065 - Fix UUID generation
uniqueness and thread safety
URL: https://github.com/apache/nifi-minifi-cpp/pull/677#discussion_r344200004
 
 

 ##########
 File path: libminifi/src/utils/Id.cpp
 ##########
 @@ -174,7 +237,7 @@ void IdGenerator::initialize(const std::shared_ptr<Properties>
& properties) {
   implementation_ = UUID_TIME_IMPL;
   if (properties->get("uid.implementation", implementation_str)) {
     std::transform(implementation_str.begin(), implementation_str.end(), implementation_str.begin(),
::tolower);
-    if ("random" == implementation_str) {
+    if ("random" == implementation_str || "windows_random" == implementation_str) {
 
 Review comment:
   I would prefer to have these constants defined somewhere in the header. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message