nifi-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [nifi] mattyb149 commented on a change in pull request #3815: NIFI-6771 : Added fix to support Oracle Binary float and Binary doubl…
Date Wed, 06 Nov 2019 13:49:22 GMT
mattyb149 commented on a change in pull request #3815: NIFI-6771 : Added fix to support Oracle
Binary float and Binary doubl…
URL: https://github.com/apache/nifi/pull/3815#discussion_r343103206
 
 

 ##########
 File path: nifi-nar-bundles/nifi-extension-utils/nifi-database-utils/src/main/java/org/apache/nifi/util/db/JdbcCommon.java
 ##########
 @@ -345,8 +345,11 @@ public static long convertToAvroStream(final ResultSet rs, final OutputStream
ou
                         byte[] bytes = rs.getBytes(i);
                         ByteBuffer bb = ByteBuffer.wrap(bytes);
                         rec.put(i - 1, bb);
-
-                    } else if (value instanceof Byte) {
+					} else if (javaSqlType == 100) { // Handle Oracle BINARY_FLOAT data type
 
 Review comment:
   The changes have tab characters rather than spaces, which causes a CheckStyle violation.
I will convert them before merging

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message