From issues-return-86814-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Thu Oct 17 13:42:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AF406180657 for ; Thu, 17 Oct 2019 15:42:54 +0200 (CEST) Received: (qmail 49944 invoked by uid 500); 17 Oct 2019 13:42:54 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 49935 invoked by uid 99); 17 Oct 2019 13:42:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Oct 2019 13:42:54 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi] joewitt commented on a change in pull request #3676: NIFI-6597 Azure Event Hub Version Update Message-ID: <157131977401.27741.16785722807060462320.gitbox@gitbox.apache.org> Date: Thu, 17 Oct 2019 13:42:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit joewitt commented on a change in pull request #3676: NIFI-6597 Azure Event Hub Version Update URL: https://github.com/apache/nifi/pull/3676#discussion_r336011505 ########## File path: nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java ########## @@ -312,11 +317,13 @@ public void onScheduled(final ProcessContext context) throws ProcessException, U receiverFetchTimeout = null; } - final String connectionString = new ConnectionStringBuilder(new URI("amqps://"+namespace+serviceBusEndpoint), eventHubName, policyName, policyKey).toString(); - setupReceiver(connectionString); + final int numThreads = context.getMaxConcurrentTasks(); + executor = Executors.newScheduledThreadPool(numThreads); Review comment: That context for Azure Event Hubs is helpful. We still would generally not want to hand off a thread pool to another library unless absolutely necessary. As we have threads available we would want to offer them to do necessary 'Event Hub interaction' and 'process received data actions' all under our control. Based on your response though it sounds like the provided threadpool approach is the API offered by event hubs at this point. OK. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services