From issues-return-86060-archive-asf-public=cust-asf.ponee.io@nifi.apache.org Wed Oct 2 08:15:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AA6F818064F for ; Wed, 2 Oct 2019 10:15:57 +0200 (CEST) Received: (qmail 44669 invoked by uid 500); 2 Oct 2019 08:15:56 -0000 Mailing-List: contact issues-help@nifi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@nifi.apache.org Delivered-To: mailing list issues@nifi.apache.org Received: (qmail 44547 invoked by uid 99); 2 Oct 2019 08:15:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2019 08:15:56 +0000 From: GitBox To: issues@nifi.apache.org Subject: [GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #635: MINIFICPP-819 - OPC Unified Architecture Support Message-ID: <157000415616.5394.8439556009179689302.gitbox@gitbox.apache.org> Date: Wed, 02 Oct 2019 08:15:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bakaid commented on a change in pull request #635: MINIFICPP-819 - OPC Unified Architecture Support URL: https://github.com/apache/nifi-minifi-cpp/pull/635#discussion_r330417917 ########## File path: extensions/opc/include/putopc.h ########## @@ -0,0 +1,111 @@ +/** + * PutOPC class declaration + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#ifndef NIFI_MINIFI_CPP_PUTOPC_H +#define NIFI_MINIFI_CPP_PUTOPC_H + +#include +#include +#include +#include +#include +#include + +#include "opc.h" +#include "opcbase.h" +#include "utils/ByteArrayCallback.h" +#include "FlowFileRecord.h" +#include "core/Processor.h" +#include "core/ProcessSession.h" +#include "core/Core.h" +#include "core/Property.h" +#include "core/Resource.h" +#include "controllers/SSLContextService.h" +#include "core/logging/LoggerConfiguration.h" +#include "utils/Id.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace processors { + +class PutOPCProcessor : public BaseOPCProcessor { + public: + static constexpr char const* ProcessorName = "PutOPC"; + // Supported Properties + static core::Property ParentNodeIDType; + static core::Property ParentNodeID; + static core::Property ParentNameSpaceIndex; + static core::Property ValueType; + + static core::Property TargetNodeIDType; + static core::Property TargetNodeID; + static core::Property TargetNodeBrowseName; + static core::Property TargetNodeNameSpaceIndex; + + // Supported Relationships + static core::Relationship Success; + static core::Relationship Failure; + + PutOPCProcessor(std::string name, utils::Identifier uuid = utils::Identifier()) Review comment: Please initialize integral typed members here too. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services